-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor unicode emoji parsing #20
Conversation
Improves performance for getByAlias and sibling methods
# Conflicts: # lib/src/main/java/net/fellbaum/jemoji/EmojiManager.java
# Conflicts: # lib/src/jmh/java/benchmark/EmojiManagerAliasBenchmark.java # lib/src/main/java/net/fellbaum/jemoji/EmojiManager.java
I also had the idea to do it in a way like you did, but didn't do it due to performance and future extension ability concerns. When it comes to performance, the refactor also seems to be worse with some methods. These were my benchmark results with the changed parameters to 10 iterations and 3 forks in a try to get more accurate results:
So currently I would tend to not merge this PR |
After discussion, the above benchmark is erroneous (look at the huge margin of error in My runs were as follow: PR #22 will require getting the char index of the emoji, which isn't necessary for most operations, so, this PR will be closed for that reason While |
Depends on #19